helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/12701 )
Change subject: KUDU-2038-p2: support for index metadata management ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12701/3/src/kudu/tablet/tablet_metadata.h File src/kudu/tablet/tablet_metadata.h: http://gerrit.cloudera.org:8080/#/c/12701/3/src/kudu/tablet/tablet_metadata.h@147 PS3, Line 147: const TableIndex& table_index() const { : const TableIndex* table_index = reinterpret_cast<const TableIndex*>( : base::subtle::Acquire_Load(reinterpret_cast<const AtomicWord*>(&table_index_))); : return *table_index; : } 1.the asan tests all passed on gerrit, but in my local debian8 sytem tablet_metadata-test and diff_scan-test failed. it seems that the code here triggers a memory leak: ================================================================= ==9094==ERROR: LeakSanitizer: detected memory leaks Direct leak of 1040 byte(s) in 1 object(s) allocated from: #0 0x50d745 in calloc /mnt/ddb/2/helif/apache/kudu/thirdparty/src/llvm-6.0.0.src/projects/compiler-rt/lib/asan/asan_malloc_linux.cc:97 #1 0x7ff2ed563d00 (/lib/x86_64-linux-gnu/libc.so.6+0x37d00) SUMMARY: AddressSanitizer: 1040 byte(s) leaked in 1 allocation(s). so i tried to comment the code of this function and returned a global static object, both of the failure ones passed. 2.the code here is similar with SetSchema() above, but i am curious why it does not complain memory leak? -- To view, visit http://gerrit.cloudera.org:8080/12701 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2d08742fa63cd3cba6452e37ec6e880532d3b104 Gerrit-Change-Number: 12701 Gerrit-PatchSet: 3 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Tue, 12 Mar 2019 00:43:33 +0000 Gerrit-HasComments: Yes
