Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12042 )
Change subject: java: add support for flaky test reporting ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/12042/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java File java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java: http://gerrit.cloudera.org:8080/#/c/12042/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java@70 PS1, Line 70: public Options revision(String revision) { > What's your expected behavior if KUDU_REPORT_TEST_RESULTS is set but one of Good question. I'd like to fail as fast and hard as possible. Meaning, rather than running through each and every test and failing it, if we could fail the entire test run that'd be ideal. If not, failing each and every test is a reasonable fallback. http://gerrit.cloudera.org:8080/#/c/12042/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java@106 PS1, Line 106: } > https://stackoverflow.com/questions/7348711 seems to be saying this is like Where do you see that? The top-voted answer describes how InetAddress.getLocalHost().getHostName() does reverse DNS and generally won't produce the same result as running `hostname`. http://gerrit.cloudera.org:8080/#/c/12042/1/java/kudu-test-utils/src/main/java/org/apache/kudu/test/junit/ResultReporter.java@120 PS1, Line 120: IsVarSetAndNonEmpty(REPORT_TIMEOUT_VAR) && > I'm fine with doing this before we push the series but I'd like to do it in That's fine. Let's explore options and see if we can't get this working with the first cut of this feature, but if it's too hard I'm also OK with enabling flaky test tracking without log files initially. -- To view, visit http://gerrit.cloudera.org:8080/12042 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I34f88363dbf52c2f7bba50fbfb5de059f88e7f74 Gerrit-Change-Number: 12042 Gerrit-PatchSet: 3 Gerrit-Owner: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 12 Mar 2019 21:24:50 +0000 Gerrit-HasComments: Yes
