Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11753 )
Change subject: authz: verify tokens on scans ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/11753/8/src/kudu/tserver/tablet_server_authorization-test.cc File src/kudu/tserver/tablet_server_authorization-test.cc: http://gerrit.cloudera.org:8080/#/c/11753/8/src/kudu/tserver/tablet_server_authorization-test.cc@367 PS8, Line 367: static constexpr char kScanTableId[] = "scan-table-id"; > warning: 'kScanTableId' is a static definition in anonymous namespace; stat Ack http://gerrit.cloudera.org:8080/#/c/11753/8/src/kudu/tserver/tablet_server_authorization-test.cc@368 PS8, Line 368: static constexpr char kScanTabletId[] = "scan-tablet-id"; > warning: 'kScanTabletId' is a static definition in anonymous namespace; sta Ack http://gerrit.cloudera.org:8080/#/c/11753/8/src/kudu/tserver/tablet_server_authorization-test.cc@369 PS8, Line 369: static constexpr char kScanUser[] = "good-guy"; > warning: 'kScanUser' is a static definition in anonymous namespace; static Ack -- To view, visit http://gerrit.cloudera.org:8080/11753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a5d81cf215a5d936f8853feba05778038764905 Gerrit-Change-Number: 11753 Gerrit-PatchSet: 8 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Mon, 18 Mar 2019 05:26:25 +0000 Gerrit-HasComments: Yes
