Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/12775 )
Change subject: [build] Make Gradle download URLs configurable ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12775/1/java/build.gradle File java/build.gradle: http://gerrit.cloudera.org:8080/#/c/12775/1/java/build.gradle@101 PS1, Line 101: > This line should be added to the wrapper task in wrapper.gradle. Done http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle.properties File java/gradle.properties: http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle.properties@63 PS1, Line 63: # The below parameters are used in the `gradle wrapper` to generate `gradlew` > Can you add a comment that these are used in the `gradle wrapper` task to g Done http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle/wrapper.gradle File java/gradle/wrapper.gradle: http://gerrit.cloudera.org:8080/#/c/12775/1/java/gradle/wrapper.gradle@59 PS1, Line 59: // fetch the jar. > Interestingly the version of the gradle jar isn't really important. Instead Done -- To view, visit http://gerrit.cloudera.org:8080/12775 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9317d8a84ccf788892163de1d89999e7749fdb34 Gerrit-Change-Number: 12775 Gerrit-PatchSet: 2 Gerrit-Owner: Attila Bukor <[email protected]> Gerrit-Reviewer: Attila Bukor <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 18 Mar 2019 17:57:40 +0000 Gerrit-HasComments: Yes
