Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12653 )
Change subject: WIP [master] introduced SentryAuthzCache ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12653/1/src/kudu/master/sentry_authz_provider.cc File src/kudu/master/sentry_authz_provider.cc: http://gerrit.cloudera.org:8080/#/c/12653/1/src/kudu/master/sentry_authz_provider.cc@319 PS1, Line 319: if (PREDICT_TRUE(cache_)) { > Nope, that's not the case. When cache is enabled and the information is no I meant when some piece of information is not in the cache, the request is made to the source to get that piece of information. Then the cache takes care of accommodating the newly fetched information: if the cache is at capacity, some existing entries are to be evicted. The policy for the eviction of entries differ (and there are many), but the principle of evicting existing entries to accommodate new ones is common for the caches, and that's how they usually work. -- To view, visit http://gerrit.cloudera.org:8080/12653 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If377cd4a7bae481ffc9a6950cb26862b66e9bab5 Gerrit-Change-Number: 12653 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Greg Solovyev <gsolov...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 19 Mar 2019 00:10:44 +0000 Gerrit-HasComments: Yes
