Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12820 )
Change subject: KUDU-2687: fix ITClient retries (take two) ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/12820/2/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java File java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java: http://gerrit.cloudera.org:8080/#/c/12820/2/java/kudu-client/src/test/java/org/apache/kudu/client/ITClient.java@117 PS2, Line 117: keepRunningLatch.countDown(); > oh, nm I see it `reportError` counts the latch down. Could you add a commen Doesn't the comment on L112-113 indicate that if there's an error, the latch counted down? In any case, the CountDownLatch.await() docs say that if it returns true, the latch has reached a count of 0. Meaning, the branch here isn't because the test is doing something special; it's just the natural way CountDownLatches are used. -- To view, visit http://gerrit.cloudera.org:8080/12820 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I31ec2d708d0ed41f25abcf09011967062c9a56c6 Gerrit-Change-Number: 12820 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Thu, 21 Mar 2019 18:45:12 +0000 Gerrit-HasComments: Yes
