Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12212 )
Change subject: [scripts] Add initial test scripts for backup/restore testing ...................................................................... Patch Set 1: (8 comments) I rebased and addressed the quick and easy reviews. I dropped the less reusable scripts and opted to keep just the backup-perf.py script to get this in. This script has been used by at least 3 people for backup/restore testing already so it makes sense to commit. http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/backup-perf.py File src/kudu/scripts/backup-perf.py: PS1: > Some of the lines in this file are too long. Done http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/backup-perf.py@223 PS1, Line 223: kudu-backup2_2.11-*.jar > Could we glob this even more aggressively so that we're resilient to Spark/ Done http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/grep_stats.py File src/kudu/scripts/grep_stats.py: PS1: > License header. Done http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/grep_stats.py@6 PS1, Line 6: for line in sys.stdin: > This script isn't used yet, and I think you could replace it with an awk sn Done http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/run_backup_tests.sh File src/kudu/scripts/run_backup_tests.sh: http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/run_backup_tests.sh@51 PS1, Line 51: NUM_TABLET_SERVERS=$((`kudu tserver list localhost -format=csv | wc -l`)) > This should be $KUDU_MASTER_ADDRESSES Done http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/run_backup_tests.sh@62 PS1, Line 62: OPTS="$OPTS --kudu-spark-tools-jar $ROOT/java/kudu-spark-tools/build/libs/kudu-spark2-tools_2.11-1.9.0-SNAPSHOT.jar" : OPTS="$OPTS --kudu-backup-jar $ROOT/java/kudu-backup/build/libs/kudu-backup2_2.11-1.9.0-SNAPSHOT.jar" > Could we glob these so we needn't update this when the version changes? Done http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/run_backup_tests.sh@81 PS1, Line 81: hadoop fs -rm -r -skipTrash $BACKUP_PATH/$TS > Should we do something like this before we get started, to clear out any le Done http://gerrit.cloudera.org:8080/#/c/12212/1/src/kudu/scripts/run_backup_tests.sh@89 PS1, Line 89: exit 0 > This isn't necessary; the script will exit with status 0 on its own at the Done -- To view, visit http://gerrit.cloudera.org:8080/12212 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0c8efc3778b20687f0c1bc4c825f49f8f24e6d3b Gerrit-Change-Number: 12212 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 22 Mar 2019 15:10:49 +0000 Gerrit-HasComments: Yes
