Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11753 )
Change subject: authz: verify tokens on scans ...................................................................... Patch Set 14: (2 comments) http://gerrit.cloudera.org:8080/#/c/11753/13//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/11753/13//COMMIT_MSG@50 PS13, Line 50: - In the latter case, in order to prevent leaking the existence (or > Nit: good explanation; might want to reformat this list using numbered item I like it better as is; this isn't really enumerating anything, and there isn't an emphasis of ordering of these points. If anything, I'd break them into separate paragraphs, but to keep consistent with the other notes here, I'm leaving it as is. http://gerrit.cloudera.org:8080/#/c/11753/13//COMMIT_MSG@55 PS13, Line 55: virtual type > Nit: a bit ambiguous; don't expect it to exist? Or don't expect it to have Done -- To view, visit http://gerrit.cloudera.org:8080/11753 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7a5d81cf215a5d936f8853feba05778038764905 Gerrit-Change-Number: 11753 Gerrit-PatchSet: 14 Gerrit-Owner: Andrew Wong <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Dan Burkert <[email protected]> Gerrit-Reviewer: Hao Hao <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 24 Mar 2019 08:00:40 +0000 Gerrit-HasComments: Yes
