Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12627 )
Change subject: KUDU-2717. Add an environment variable override for username ...................................................................... Patch Set 3: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/12627/3/src/kudu/util/user.cc File src/kudu/util/user.cc: http://gerrit.cloudera.org:8080/#/c/12627/3/src/kudu/util/user.cc@45 PS3, Line 45: const char* override_username = getenv("KUDU_USER_NAME"); Do you think KUDU_USER_NAME might be common enough in an environment it could be accidentally used? Maybe `KUDU_USER_OVERRIDE`? -- To view, visit http://gerrit.cloudera.org:8080/12627 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9d42a3efbf26882f086046c276d5f9965a4068f5 Gerrit-Change-Number: 12627 Gerrit-PatchSet: 3 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Thu, 28 Mar 2019 19:14:15 +0000 Gerrit-HasComments: Yes
