Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/12825 )
Change subject: [util] introduce TTL cache ...................................................................... Patch Set 9: (2 comments) http://gerrit.cloudera.org:8080/#/c/12825/7//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/12825/7//COMMIT_MSG@10 PS7, Line 10: > nit: extra space. Ah, that's intentional. I found this two-spaces-after-full-stop to be easier to read, and since we don't have strict style guide for descriptions of git changelists, I'm taking advantage of those loose rules :) However, it seems we have some stricter rules for comments in the code, where there should be no duplicate spaces, even after full stop. http://gerrit.cloudera.org:8080/#/c/12825/7/src/kudu/util/ttl_cache_test_metrics.cc File src/kudu/util/ttl_cache_test_metrics.cc: http://gerrit.cloudera.org:8080/#/c/12825/7/src/kudu/util/ttl_cache_test_metrics.cc@54 PS7, Line 54: tricUnit::kBytes, > nit: rename it to test_ttl_cache_memory_usage? Ah, that's just test piece. Maybe in one of follow-up commits? -- To view, visit http://gerrit.cloudera.org:8080/12825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic8aa0ebe6b26bf34ca0e02bebbdb6a94f6b00621 Gerrit-Change-Number: 12825 Gerrit-PatchSet: 9 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Fri, 29 Mar 2019 00:25:41 +0000 Gerrit-HasComments: Yes
