Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12891 )
Change subject: client: convert the has_foo booleans into boost::optional ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12891/2/src/kudu/client/schema-internal.h File src/kudu/client/schema-internal.h: http://gerrit.cloudera.org:8080/#/c/12891/2/src/kudu/client/schema-internal.h@63 PS2, Line 63: primary_key(false), : remove_default(false) { Nit: indent a bit further so they're aligned with 'name' http://gerrit.cloudera.org:8080/#/c/12891/2/src/kudu/client/schema.cc File src/kudu/client/schema.cc: http://gerrit.cloudera.org:8080/#/c/12891/2/src/kudu/client/schema.cc@353 PS2, Line 353: RETURN_NOT_OK(data_->default_val.value()->data_->CheckTypeAndGetPointer( data_->default_val->data_->CheckTypeAndGetPointer http://gerrit.cloudera.org:8080/#/c/12891/2/src/kudu/client/schema.cc@418 PS2, Line 418: return data_->default_val.value()->data_->GetSlice(); I think this can be data_->default_val->data_->GetSlice(); -- To view, visit http://gerrit.cloudera.org:8080/12891 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia4e7319c617bd388730d6e81378b37eb6793cf24 Gerrit-Change-Number: 12891 Gerrit-PatchSet: 2 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Sat, 30 Mar 2019 23:04:19 +0000 Gerrit-HasComments: Yes
