Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12912 )
Change subject: [master_sentry-itest] add description into AuthzFuncs ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12912/1/src/kudu/integration-tests/master_sentry-itest.cc File src/kudu/integration-tests/master_sentry-itest.cc: http://gerrit.cloudera.org:8080/#/c/12912/1/src/kudu/integration-tests/master_sentry-itest.cc@493 PS1, Line 493: static const AuthzDescriptor kAuthzCombinations[] = { For this and kAuthzFuncCombinations, it'd be even clearer if you used the exact RPC name in the description. For example, instead of "create table", use "CreateTable". Or "GetTableLocations". etc. -- To view, visit http://gerrit.cloudera.org:8080/12912 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08934c8e74b2d6f72dd703a304e48befffd2e6fc Gerrit-Change-Number: 12912 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 02 Apr 2019 17:28:29 +0000 Gerrit-HasComments: Yes
