Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12918 )
Change subject: util: pull Random methods out from tests ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/12918/3/src/kudu/util/random.h File src/kudu/util/random.h: http://gerrit.cloudera.org:8080/#/c/12918/3/src/kudu/util/random.h@149 PS3, Line 149: > Could you add ThreadSafeRandom equivalents too? I wonder if we should move these methods as well as the other "utility" methods like ReservoirSample into random_util.h instead? We could templatize them on the RNG and avoid having to duplicate all the methods. -- To view, visit http://gerrit.cloudera.org:8080/12918 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie74eca50d770b9470f6cfb400cf632381a20bd93 Gerrit-Change-Number: 12918 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Wed, 03 Apr 2019 17:44:48 +0000 Gerrit-HasComments: Yes