Yingchun Lai has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/12932 )

Change subject: [kudu-tool-test] deflake 
ToolTestCopyTableParameterized.TestCopyTable
......................................................................


Patch Set 1:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc
File src/kudu/tools/kudu-tool-test.cc:

http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@572
PS1, Line 572:       // Rows scaned from source table can be found in 
destination table.
> scanned
Done


http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@583
PS1, Line 583: has
> Nit: "should have"
Done


http://gerrit.cloudera.org:8080/#/c/12932/1/src/kudu/tools/kudu-tool-test.cc@643
PS1, Line 643:     ww.set_write_batch_size(1);
> Why this change?
Not related, I'll remove it.



--
To view, visit http://gerrit.cloudera.org:8080/12932
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I089bdd5e737f4eef94068303516ceb0d5ddd3abb
Gerrit-Change-Number: 12932
Gerrit-PatchSet: 1
Gerrit-Owner: Yingchun Lai <405403...@qq.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yingchun Lai <405403...@qq.com>
Gerrit-Comment-Date: Fri, 05 Apr 2019 13:45:10 +0000
Gerrit-HasComments: Yes

Reply via email to