Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12936 )
Change subject: [build] Fix building codegen on MacOS Mojave ...................................................................... [build] Fix building codegen on MacOS Mojave When macOS_SDK_headers_for_macOS_10.14 is installed setting the --sysroot to the default header location breaks the build, which is why there was a check whether /usr/include existed and only set --sysroot to the SDK path if it didn't. The problem with this is if something creates the /usr/include directory, the build will fail again. This commit changes the check to look for /usr/include/libc.h instead. Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Reviewed-on: http://gerrit.cloudera.org:8080/12936 Reviewed-by: Attila Bukor <abu...@apache.org> Tested-by: Attila Bukor <abu...@apache.org> --- M src/kudu/codegen/CMakeLists.txt 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Attila Bukor: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/12936 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I29ec74014bee3121bfb4a203dd7bfa8bac8f8321 Gerrit-Change-Number: 12936 Gerrit-PatchSet: 3 Gerrit-Owner: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Attila Bukor <abu...@apache.org> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
