Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/12949 )
Change subject: KUDU-2689: Made PartialRow setters use a fluent-style. ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/12949/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java File java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java: http://gerrit.cloudera.org:8080/#/c/12949/1/java/kudu-client/src/main/java/org/apache/kudu/client/PartialRow.java@118 PS1, Line 118: * @return a PartialRow Here and below. "this PartialRow" It's important because it clearly indicates it's this row mutated, as opposed to a new PartialRow. http://gerrit.cloudera.org:8080/#/c/12949/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java: http://gerrit.cloudera.org:8080/#/c/12949/1/java/kudu-client/src/test/java/org/apache/kudu/client/TestPartialRow.java@411 PS1, Line 411: .addShort("int16", (short) 43) Nit: I think this is too indented. Should be 4 spaces. -- To view, visit http://gerrit.cloudera.org:8080/12949 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3476fb3c0a28812e2732e6c6268f31a393928206 Gerrit-Change-Number: 12949 Gerrit-PatchSet: 1 Gerrit-Owner: Anonymous Coward <raym...@phdata.io> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Brian McDevitt <br...@phdata.io> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Sat, 06 Apr 2019 21:33:10 +0000 Gerrit-HasComments: Yes
