Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/12907 )
Change subject: remove schema copies from RowBlock and RowBuilder ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/12907/5/src/kudu/common/rowblock.h File src/kudu/common/rowblock.h: http://gerrit.cloudera.org:8080/#/c/12907/5/src/kudu/common/rowblock.h@195 PS5, Line 195: RowBlock(const Schema* schema, mind adding a comment just to indicate the lifetime requirements of 'schema' and 'arena'? It should be clear from convention but just to be extra careful. -- To view, visit http://gerrit.cloudera.org:8080/12907 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie4d60640b2bac4f2b3077ddd696966e1f6658740 Gerrit-Change-Number: 12907 Gerrit-PatchSet: 5 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 09 Apr 2019 17:33:53 +0000 Gerrit-HasComments: Yes
