Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/12945 )
Change subject: tool: perf tablet_scan action ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/12945/2/src/kudu/tools/tool_action_perf.cc File src/kudu/tools/tool_action_perf.cc: http://gerrit.cloudera.org:8080/#/c/12945/2/src/kudu/tools/tool_action_perf.cc@744 PS2, Line 744: FsManagerOpts()); BTW can this tool be run on a currently-running tablet server? Is it read-only enough? http://gerrit.cloudera.org:8080/#/c/12945/2/src/kudu/tools/tool_action_perf.cc@756 PS2, Line 756: if (FLAGS_use_hybrid_clock) { : clock.reset(new HybridClock()); : } else { : clock.reset(LogicalClock::CreateStartingAt(Timestamp::kInitialTimestamp)); : } What does using the hybrid clock get us as far as scans are concerned? Could we always just use the logical clock? http://gerrit.cloudera.org:8080/#/c/12945/2/src/kudu/tools/tool_action_perf.cc@869 PS2, Line 869: "Scan the contents of a local tablet" nit: probably worth noting that this doesn't actually output the rows, other than a count. -- To view, visit http://gerrit.cloudera.org:8080/12945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4667dcb2d9a21d77149ebdae2e29b7fce8b460b Gerrit-Change-Number: 12945 Gerrit-PatchSet: 2 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 09 Apr 2019 19:10:26 +0000 Gerrit-HasComments: Yes
