Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/12944 )
Change subject: generic_iterators: switch MergeIterator to intrusive list of states ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/12944/1/src/kudu/common/generic_iterators.cc File src/kudu/common/generic_iterators.cc: http://gerrit.cloudera.org:8080/#/c/12944/1/src/kudu/common/generic_iterators.cc@106 PS1, Line 106: MergeIterStateList > nit: maybe just call this 'List' so it's not redundantrly MergerIterState:: Done -- To view, visit http://gerrit.cloudera.org:8080/12944 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1a165858e37c3e0a6ef85e46e20078c264fa8a65 Gerrit-Change-Number: 12944 Gerrit-PatchSet: 1 Gerrit-Owner: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Tue, 09 Apr 2019 20:45:05 +0000 Gerrit-HasComments: Yes