Andrew Wong has submitted this change and it was merged. (
http://gerrit.cloudera.org:8080/12988 )
Change subject: tools: escape brackets when generating XML
......................................................................
tools: escape brackets when generating XML
When building the site, we generate the XML for tools. Usually we escape
ambiguous characters for tooling arguments; it seems that wasn't the
case for arguments that are GFlags. This meant that before, we would run
into errors like the following when generating the site (new in 1.9.0
for the --predicates argument of the new `table scan` tool):
/kudu/build/release/gen-docs/kudu.xml:49: parser error : StartTag: invalid
element name
* The 'Comparison' type supports <=, <, =, >, and >=,
^
Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Reviewed-on: http://gerrit.cloudera.org:8080/12981
Reviewed-by: Adar Dembo <[email protected]>
Reviewed-by: Grant Henke <[email protected]>
Tested-by: Andrew Wong <[email protected]>
(cherry picked from commit 4eb74ae233fadf5184632f4b291b0befeb371dd5)
Reviewed-on: http://gerrit.cloudera.org:8080/12988
Tested-by: Kudu Jenkins
---
M src/kudu/tools/tool_action.cc
1 file changed, 3 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12988
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: branch-1.9.x
Gerrit-MessageType: merged
Gerrit-Change-Id: I16c13d86b0b452e0559e245ee33373078e5e3713
Gerrit-Change-Number: 12988
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Andrew Wong <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <[email protected]>
