Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13024 )
Change subject: [ksck] Make ksck tool more concurrent ...................................................................... Patch Set 4: (2 comments) The test failures look legitimate. http://gerrit.cloudera.org:8080/#/c/13024/4/src/kudu/tools/ksck.cc File src/kudu/tools/ksck.cc: http://gerrit.cloudera.org:8080/#/c/13024/4/src/kudu/tools/ksck.cc@166 PS4, Line 166: RETURN_NOT_OK(ThreadPoolBuilder("ksck-fetch") : .set_max_threads(FLAGS_fetch_info_concurrency > 0 ? : FLAGS_fetch_info_concurrency : num_masters) : .set_idle_timeout(MonoDelta::FromMilliseconds(10)) : .Build(&pool_)); Why do this here and not in the constructor? http://gerrit.cloudera.org:8080/#/c/13024/4/src/kudu/tools/ksck_remote.cc File src/kudu/tools/ksck_remote.cc: http://gerrit.cloudera.org:8080/#/c/13024/4/src/kudu/tools/ksck_remote.cc@512 PS4, Line 512: RETURN_NOT_OK(ThreadPoolBuilder("RetrieveTablesList") : .set_max_threads(FLAGS_fetch_info_concurrency) : .set_idle_timeout(MonoDelta::FromMilliseconds(10)) : .Build(&pool_)); Likewise, this seems better placed in the RemoteKsckCluster constructor. -- To view, visit http://gerrit.cloudera.org:8080/13024 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2f3f0e3f5115a46dd3afc83dda75e7241618eea4 Gerrit-Change-Number: 13024 Gerrit-PatchSet: 4 Gerrit-Owner: Yingchun Lai <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Reviewer: Yingchun Lai <[email protected]> Gerrit-Comment-Date: Thu, 18 Apr 2019 04:20:10 +0000 Gerrit-HasComments: Yes
