Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13073 )
Change subject: hms: skip drop table notification log for external table ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13073/1/src/kudu/integration-tests/hms_itest-base.cc File src/kudu/integration-tests/hms_itest-base.cc: http://gerrit.cloudera.org:8080/#/c/13073/1/src/kudu/integration-tests/hms_itest-base.cc@148 PS1, Line 148: AlterTable I'm curious whether: * it's necessary to set kKuduTableIdKey property as well? * this method can be successfully called multiple times producing the same result (i.e. whether it's idempotent)? http://gerrit.cloudera.org:8080/#/c/13073/1/src/kudu/tools/tool_action_hms.cc File src/kudu/tools/tool_action_hms.cc: http://gerrit.cloudera.org:8080/#/c/13073/1/src/kudu/tools/tool_action_hms.cc@175 PS1, Line 175: hms_table_copy == hms_table I'm curious whether this comparison will work after overriding the HmsClient::kExternalTableKey parameter in the 'hms_table_copy'? Shouldn't we also somehow do the same for 'hms_table'? -- To view, visit http://gerrit.cloudera.org:8080/13073 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ffb23d507cc0d9ba9e46983e5bbf6b7116f7515 Gerrit-Change-Number: 13073 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Wed, 24 Apr 2019 07:41:56 +0000 Gerrit-HasComments: Yes
