Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13130 )
Change subject: [backup] Add more metadata fields ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG@9 PS1, Line 9: This patch adds more metadata fields to the metdata metadata http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG@13 PS1, Line 13: - table_id: Can be used in the future to handle dropped Nit: indentation http://gerrit.cloudera.org:8080/#/c/13130/1//COMMIT_MSG@15 PS1, Line 15: - comment: Used to backup and restore column coments. comments http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-backup/src/main/protobuf/backup.proto File java/kudu-backup/src/main/protobuf/backup.proto: http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-backup/src/main/protobuf/backup.proto@120 PS1, Line 120: // A map of column name to internal column id. : // This is useful for detecting dropped and added columns. Can you doc why column IDs are here and not in ColumnMetadataPB? You could always build a map at runtime after loading the protobuf. Also, should we track all column IDs that ever existed? Or the max column ID? Would either be useful to backup/restore? http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-client/src/main/java/org/apache/kudu/Schema.java File java/kudu-client/src/main/java/org/apache/kudu/Schema.java: PS1: Do you remember off-hand when the master supplies a schema with column IDs vs. without? http://gerrit.cloudera.org:8080/#/c/13130/1/java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java File java/kudu-client/src/main/java/org/apache/kudu/util/SchemaGenerator.java: PS1: Hmm, why isn't this in src/test/java? -- To view, visit http://gerrit.cloudera.org:8080/13130 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I42458f598a523596acb9f18558e6f518719a969b Gerrit-Change-Number: 13130 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Fri, 26 Apr 2019 19:03:40 +0000 Gerrit-HasComments: Yes
