Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13133 )

Change subject: sentry: remove experimental tag from sentry flags
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13133/1/src/kudu/master/sentry_privileges_fetcher.cc
File src/kudu/master/sentry_privileges_fetcher.cc:

http://gerrit.cloudera.org:8080/#/c/13133/1/src/kudu/master/sentry_privileges_fetcher.cc@116
PS1, Line 116: DEFINE_uint32(sentry_privileges_cache_capacity_mb, 256,
Not related to this patch, but we should validate that this is less than the 
memory limit, and maybe even less than the memory limit + the block cache 
capacity.



--
To view, visit http://gerrit.cloudera.org:8080/13133
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1a43a6d4b02402843af787479456954871ed07cd
Gerrit-Change-Number: 13133
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 26 Apr 2019 21:21:16 +0000
Gerrit-HasComments: Yes

Reply via email to