Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13173 )
Change subject: [backup] Support column alterations between backups ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13173/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala File java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala: http://gerrit.cloudera.org:8080/#/c/13173/2/java/kudu-backup/src/main/scala/org/apache/kudu/backup/KuduRestore.scala@172 PS2, Line 172: log.error(s"currentColumns: $currentColumns") You want this to show as error? Why not info? http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala File java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala: http://gerrit.cloudera.org:8080/#/c/13173/1/java/kudu-backup/src/test/scala/org/apache/kudu/backup/TestKuduBackup.scala@287 PS1, Line 287: val options = new CreateTableOptions() > I added this because some partition is required and this was easiest. You find this easier than .setRangePartitionColumns(List("key"))? I prefer that because it means, when reviewing the test, you don't have to remember the detail of there being 3 buckets thinking it might prove important later on. -- To view, visit http://gerrit.cloudera.org:8080/13173 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I15e159caf485d83f4d5a36305d677828840bff03 Gerrit-Change-Number: 13173 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Comment-Date: Tue, 30 Apr 2019 04:00:29 +0000 Gerrit-HasComments: Yes
