Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13188 )
Change subject: replace nvml with memkind in block cache ...................................................................... Patch Set 1: I don't have a lot of context or knowledge of these libraries so I have a few high level questions. 1. What is the motivation for this change? Is there an expected performance or stability improvement? 2. Why did you change to memkind from nvml? Note: the nvml library looks like it changed names/repos (https://github.com/pmem/pmdk) -- To view, visit http://gerrit.cloudera.org:8080/13188 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08855c62bc42b9e6f7a4b3bfa27a708ed2c133f5 Gerrit-Change-Number: 13188 Gerrit-PatchSet: 1 Gerrit-Owner: ye yuqiang <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 16:04:14 +0000 Gerrit-HasComments: No
