Will Berkeley has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13200 )
Change subject: Deflake ClientTest.TestServerTooBusyRetry ...................................................................... Deflake ClientTest.TestServerTooBusyRetry ClientTest.TestServerTooBusyRetry is a mess of a test. In TSAN mode, there are less rows inserted, so scans require less round trips to complete, but at the same time threads start slower, so the number of scans in-flight at once will tend to be lower. This causes the test to occasionally fail to cause a service queue overflow, as it is intended to do. Eventually, the test fails because TSAN has an upper bound on the number of threads that can be created in the lifetime of a single TSAN process, and the test slowly creates scan threads. This patch attempts to address the problem by raising the scan batch latency in TSAN mode. With this patch, I saw 0 failures in 1000 runs. Without it, I got tired of waiting for 850/1000 to finish after 15 minutes. This is a quick fix. In the future someone should consider a more serious rewrite of this test. Change-Id: Id4d2ee077e9d107fb475c399af5690084bdeef49 Reviewed-on: http://gerrit.cloudera.org:8080/13200 Reviewed-by: Adar Dembo <[email protected]> Tested-by: Kudu Jenkins --- M src/kudu/client/client-test.cc 1 file changed, 4 insertions(+), 0 deletions(-) Approvals: Adar Dembo: Looks good to me, approved Kudu Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/13200 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: Id4d2ee077e9d107fb475c399af5690084bdeef49 Gerrit-Change-Number: 13200 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Will Berkeley <[email protected]>
