Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13201 )
Change subject: [TTL cache] add periodic scrubbing thread ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13201/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13201/1//COMMIT_MSG@10 PS1, Line 10: , > drop this Done http://gerrit.cloudera.org:8080/#/c/13201/1/src/kudu/util/ttl_cache.h File src/kudu/util/ttl_cache.h: http://gerrit.cloudera.org:8080/#/c/13201/1/src/kudu/util/ttl_cache.h@264 PS1, Line 264: return valid_entry_count == 0; > Not understanding the rationale here. My bad: I forgot to comment on the reasoning. I added corresponding comment. I hope it's clearer now. -- To view, visit http://gerrit.cloudera.org:8080/13201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib3bbbcf6211930a5501a03d6a47f3d911118946c Gerrit-Change-Number: 13201 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 30 Apr 2019 23:54:50 +0000 Gerrit-HasComments: Yes
