Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13205 )
Change subject: [authz] add scrubbing task for the privileges cache ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/13205/4/src/kudu/master/sentry_privileges_fetcher.cc File src/kudu/master/sentry_privileges_fetcher.cc: http://gerrit.cloudera.org:8080/#/c/13205/4/src/kudu/master/sentry_privileges_fetcher.cc@131 PS4, Line 131: DEFINE_uint32(sentry_privileges_cache_scrubbing_period_sec, 20, The implication here that maybe should be noted (though maybe not) is that every 20 seconds, we'll lock the cache to do the scrubbing. In the happy case where there isn't much to scrub, we'll short-circuit early because we'll see a valid entry in the cache. In the unhappy case where there is a lot to scrub, the locking is warranted because there's a decent amount of work being done (i.e. many entries are being deleted). Probably not worth adding all that to the description, but just validating my understanding of the scrubbing. -- To view, visit http://gerrit.cloudera.org:8080/13205 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I88510fae48cf683fbfad8a11c2941a23b2af9f8b Gerrit-Change-Number: 13205 Gerrit-PatchSet: 4 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Wed, 01 May 2019 20:17:14 +0000 Gerrit-HasComments: Yes
