Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13139 )
Change subject: [tools] command to reset authz cache in kudu CLI ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13139/5/src/kudu/tools/tool_action_master.cc File src/kudu/tools/tool_action_master.cc: http://gerrit.cloudera.org:8080/#/c/13139/5/src/kudu/tools/tool_action_master.cc@187 PS5, Line 187: if (resp_master_addrs.size() != master_addresses.size()) { > Does this mean the tool can't be used if the masters have a configuration i It seemed to me that the consensus was that we want to make the reset operation for the caches as consistent as possible. Resetting them at once at every master helps to prevent inconsistencies upon master leadership change. I think I'll add a --force flag: if the --force flag specified, the validation of master addresses will be skipped. -- To view, visit http://gerrit.cloudera.org:8080/13139 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If49f3ebdea22ea0df3aaec313b4db949dc834943 Gerrit-Change-Number: 13139 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Sat, 04 May 2019 01:43:19 +0000 Gerrit-HasComments: Yes
