Adar Dembo has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13246 )

Change subject: KUDU-2810: [backup] Add workaround DELETE IGNORE support
......................................................................


Patch Set 3: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/13246/3/java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java
File java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java:

http://gerrit.cloudera.org:8080/#/c/13246/3/java/kudu-client/src/main/java/org/apache/kudu/client/Batch.java@65
PS3, Line 65:   private final EnumSet<ErrorCode> ignoredErrors;
I think you could continue to use an interface type (i.e. Set) here.



--
To view, visit http://gerrit.cloudera.org:8080/13246
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib718b72a73b06d9b9dc809fde3c52a1d498ceb23
Gerrit-Change-Number: 13246
Gerrit-PatchSet: 3
Gerrit-Owner: Grant Henke <[email protected]>
Gerrit-Reviewer: Adar Dembo <[email protected]>
Gerrit-Reviewer: Grant Henke <[email protected]>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Mike Percy <[email protected]>
Gerrit-Reviewer: Will Berkeley <[email protected]>
Gerrit-Comment-Date: Mon, 06 May 2019 18:36:00 +0000
Gerrit-HasComments: Yes

Reply via email to