Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13317 )
Change subject: Allow alter legacy tables in Hive Metastore Kudu plugin ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/13317/5/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13317/5/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@258 PS5, Line 258: // Check that altering table with Kudu storage handler to legacy format : // succeeds. : { : Table alteredTable = table.deepCopy(); : alteredTable.getParameters().clear(); : alteredTable.putToParameters(hive_metastoreConstants.META_TABLE_STORAGE, : KuduMetastorePlugin.LEGACY_KUDU_STORAGE_HANDLER); : alteredTable.putToParameters(KuduMetastorePlugin.LEGACY_KUDU_TABLE_NAME, : "legacy_table"); : alteredTable.putToParameters(KuduMetastorePlugin.KUDU_MASTER_ADDRS_KEY, : "localhost"); : client.alter_table(table.getDbName(), table.getTableName(), alteredTable); : } > Even with recent development which is to always use new storage handler goi In the case a user needs to downgrade to <Impala 3.3 they will also need to disable HMS integration which will disable this plugin. -- To view, visit http://gerrit.cloudera.org:8080/13317 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie76ce2cd7dda0b4391e91abe2da2801d305a64d3 Gerrit-Change-Number: 13317 Gerrit-PatchSet: 5 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 20 May 2019 13:28:30 +0000 Gerrit-HasComments: Yes
