Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/13381 )
Change subject: hms: synchronize column comments to the HMS ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/13381/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13381/1//COMMIT_MSG@7 PS1, Line 7: syncronize > synchronize Done http://gerrit.cloudera.org:8080/#/c/13381/1//COMMIT_MSG@10 PS1, Line 10: syncronized > synchronized Done http://gerrit.cloudera.org:8080/#/c/13381/1/src/kudu/integration-tests/master_hms-itest.cc File src/kudu/integration-tests/master_hms-itest.cc: http://gerrit.cloudera.org:8080/#/c/13381/1/src/kudu/integration-tests/master_hms-itest.cc@245 PS1, Line 245: comment_alterer->AlterColumn("key")->Comment("Sample Comment"); > Does it make sense to add a scenario that verifies that setting the comment > empty (or otherwise clearing the comment) reflects in the HMS as well? Or we > have some other means to make sure this corner case works as expected? Sure I can do this. > Also, what about a scenario when a new column is being added with a comment? There is nothing unique about this case code wise, so testing feels a bit overkill. > And is it going to work for non-key columns as well? The HMS has no concept of key columns, this works the same for all columns. > What if a column is renamed -- should the comment transparently appear in HMS > as an attribute of the renamed column? Yes, column renames have no interaction or impact on this. -- To view, visit http://gerrit.cloudera.org:8080/13381 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I12da391ea74e153483b6657e7028aa6784ac41b3 Gerrit-Change-Number: 13381 Gerrit-PatchSet: 1 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Tue, 21 May 2019 15:05:55 +0000 Gerrit-HasComments: Yes
