Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13380 )
Change subject: [tool-test] scenario for ksck and unusual tserver flags ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13380/1/src/kudu/tools/kudu-tool-test.cc File src/kudu/tools/kudu-tool-test.cc: http://gerrit.cloudera.org:8080/#/c/13380/1/src/kudu/tools/kudu-tool-test.cc@4538 PS1, Line 4538: // Run tablet servers with a few flags considered unusual by ksck. > Could you doc why these custom values are useful? Yep, you are right -- these are not actually necessary to tickle the race. The important thing to have for the race is unavailability of tablet servers. And yes, due to the test setup that we have for mini-cluster, the 'unusual' flags are actually there already (in addition to those specified here explicitly). However, these were useful to distinguish between crash/race and normal run. Probably, I can do better in that regard and distinguish between the latter by some other means. -- To view, visit http://gerrit.cloudera.org:8080/13380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16cf69b6f7d2fb59014df26601dfc30e124a52ee Gerrit-Change-Number: 13380 Gerrit-PatchSet: 1 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Tue, 21 May 2019 20:51:51 +0000 Gerrit-HasComments: Yes
