Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13424 )
Change subject: hms plugin: don't expect table type ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/13424/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13424/1//COMMIT_MSG@10 PS1, Line 10: This > It's great that you fixed that. I think the stack below is attributed to t Andrew mentioned that the actual code might be even something else, but anyways it would not hurt to address the issue when Table.getParameters() returns null. http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13424/1/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@107 PS1, Line 107: checkNoKuduProperties(table) > By my understanding, the NPE happened because table parameters was null (th Andrew pointed that the actual code might be even something else. -- To view, visit http://gerrit.cloudera.org:8080/13424 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If76533a94f6ef2ae135af4bd441fc2652a6a5dda Gerrit-Change-Number: 13424 Gerrit-PatchSet: 1 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 24 May 2019 18:57:12 +0000 Gerrit-HasComments: Yes
