Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13469 )
Change subject: KUDU-2791: TTL cache in DNS resolver (part 2) ...................................................................... Patch Set 5: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h File src/kudu/kserver/kserver.h: http://gerrit.cloudera.org:8080/#/c/13469/2/src/kudu/kserver/kserver.h@72 PS2, Line 72: gscoped_ptr<ThreadPool> raft_pool_; > I thought it might be used by objects which are still alive when KuduServer It might become more of an issue if/when more of our DNS resolution is asynchronous and we're trying to gracefully shutdown servers in tests (see KUDU-2439). But that should be fixed directly, and it's not an issue in production. -- To view, visit http://gerrit.cloudera.org:8080/13469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib22e87d28573fdb93ba18cd6d99d8bde7524a4fc Gerrit-Change-Number: 13469 Gerrit-PatchSet: 5 Gerrit-Owner: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Sun, 02 Jun 2019 21:22:30 +0000 Gerrit-HasComments: Yes
