Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/13492 )
Change subject: [hms] Support repairing entries with invalid IDs ...................................................................... Patch Set 2: Code-Review+1 (1 comment) LGTM, just one minor issue. Thanks a lot for patch! http://gerrit.cloudera.org:8080/#/c/13492/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java File java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13492/2/java/kudu-hive/src/main/java/org/apache/kudu/hive/metastore/KuduMetastorePlugin.java@320 PS2, Line 320: return Boolean.parseBoolean(properties.get(KUDU_MASTER_EVENT)); Not your fault, but can you add 'containsKey' check before this? Thanks! -- To view, visit http://gerrit.cloudera.org:8080/13492 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I437a8b42182dcfa09972f8059ccb6af280925085 Gerrit-Change-Number: 13492 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Mon, 03 Jun 2019 04:14:02 +0000 Gerrit-HasComments: Yes