Will Berkeley has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/13497 )

Change subject: [java] Deflake 
TestKuduSession.testInsertAutoFlushBackgroundNonCoveredRange
......................................................................

[java] Deflake TestKuduSession.testInsertAutoFlushBackgroundNonCoveredRange

The test uses an AsyncKuduSession in AUTO_FLUSH_BACKGROUND mode to send
20 inserts. 10 of them should fail because they are in a non-covered
range. However, the test did not join on the deferred when it called
AsyncKuduSession#flush. Therefore, there was no guarantee the operations
had been completed. So, every now and then, the ops were still in flight
when the errors were checked, causing the test to fail because it saw no
error where it expected to see errors.

Before this fix, the test failed because of this problem about 1/1000
times. I ran 1000 with the fix and saw no failures, but the rate was so
low maybe I was lucky. Regardless, I'm confident the test is more
correct with this fix.

Change-Id: I40360e9c7979c2edf01b4a70b64f71af4d1a1e11
Reviewed-on: http://gerrit.cloudera.org:8080/13497
Tested-by: Will Berkeley <wdberke...@gmail.com>
Reviewed-by: Grant Henke <granthe...@apache.org>
---
M java/kudu-client/src/test/java/org/apache/kudu/client/TestKuduSession.java
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Will Berkeley: Verified
  Grant Henke: Looks good to me, approved

--
To view, visit http://gerrit.cloudera.org:8080/13497
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I40360e9c7979c2edf01b4a70b64f71af4d1a1e11
Gerrit-Change-Number: 13497
Gerrit-PatchSet: 2
Gerrit-Owner: Will Berkeley <wdberke...@gmail.com>
Gerrit-Reviewer: Adar Dembo <a...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>

Reply via email to