Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13524 )
Change subject: [hms] disallow table type altering via table property ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/13524/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java File java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java: http://gerrit.cloudera.org:8080/#/c/13524/1/java/kudu-hive/src/test/java/org/apache/kudu/hive/metastore/TestKuduMetastorePlugin.java@274 PS1, Line 274: alteredTable.putToParameters(KuduMetastorePlugin.EXTERNAL_TABLE_KEY, "true"); > The expected behavior should be ok to do so. Add such a test. OK, I'll add that in my systests. -- To view, visit http://gerrit.cloudera.org:8080/13524 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7c6d490f7714770c6544859ca8477e6e765a06b3 Gerrit-Change-Number: 13524 Gerrit-PatchSet: 1 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Thu, 06 Jun 2019 03:57:00 +0000 Gerrit-HasComments: Yes
