Will Berkeley has posted comments on this change. ( http://gerrit.cloudera.org:8080/13521 )
Change subject: [c++] Support table rename between scan token creation and rehydration ...................................................................... Patch Set 4: (7 comments) http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/client-internal.h File src/kudu/client/client-internal.h: http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/client-internal.h@148 PS3, Line 148: // 'table_id_or_name' should contain a table id or name as 'identifier_type' : // is ID or NAME, respectively. : Status GetTableSchema(KuduClien > Update this. Done http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/client-internal.h@156 PS3, Line 156: std::string* table_name, : int* num_replicas); > You could also make the contract such that 'table' is both IN and OUT, and Negatory. http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/client-internal.cc File src/kudu/client/client-internal.cc: http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/client-internal.cc@457 PS3, Line 457: const TableIdentifierPB& table_identifier, > warning: the parameter 'table_identifier' is copied for each invocation but Done http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/client-internal.cc@457 PS3, Line 457: const TableIdentifierPB& table_identifier, > Agreed with clang-tidy here (and below). Done http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/client-internal.cc@497 PS3, Line 497: const TableIdentifierPB& table, > warning: the parameter 'table' is copied for each invocation but only used Done http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/scan_token-internal.cc File src/kudu/client/scan_token-internal.cc: http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/scan_token-internal.cc@48 PS3, Line 48: #include "kudu/gutil/ref_counted.h" > And this too. Done http://gerrit.cloudera.org:8080/#/c/13521/3/src/kudu/client/scan_token-internal.cc@48 PS3, Line 48: #include "kudu/gutil/ref_counted.h" > warning: #includes are not sorted properly [llvm-include-order] Done -- To view, visit http://gerrit.cloudera.org:8080/13521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib4d48513dff67012f26a99877b168d777d3049fd Gerrit-Change-Number: 13521 Gerrit-PatchSet: 4 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com> Gerrit-Comment-Date: Fri, 07 Jun 2019 21:11:23 +0000 Gerrit-HasComments: Yes
