Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13537 )
Change subject: KUDU-2809 (5/6): add diff scan support to fuzz-itest ...................................................................... Patch Set 8: (3 comments) http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc File src/kudu/integration-tests/fuzz-itest.cc: http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@603 PS7, Line 603: row*/) > nit: /*expected_row*/ (ignored is clear from being commented out) Will use 'row' to be more consistent with 'is_deleted' below. http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@612 PS7, Line 612: is_dele > nit: I think a better name would be /*is_deleted*/ or /*element*/ Done http://gerrit.cloudera.org:8080/#/c/13537/7/src/kudu/integration-tests/fuzz-itest.cc@615 PS7, Line 615: row_key++; > This is pretty clever... is this relying on defined behavior for std::remov It's basically a silly way to maintain an index for expected_is_deleted while still calling erase with remove_if (which is a more efficient way to erase). So it's actually relying on erase(..., start_iter, end_iter) semantics, which, if you pass in vector::begin and vector::end, gives you in-index-order iteration. -- To view, visit http://gerrit.cloudera.org:8080/13537 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3f7dae20ef1b903dba80e90d5f491e4322815fbb Gerrit-Change-Number: 13537 Gerrit-PatchSet: 8 Gerrit-Owner: Adar Dembo <[email protected]> Gerrit-Reviewer: Adar Dembo <[email protected]> Gerrit-Reviewer: Grant Henke <[email protected]> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <[email protected]> Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Will Berkeley <[email protected]> Gerrit-Comment-Date: Fri, 07 Jun 2019 21:34:24 +0000 Gerrit-HasComments: Yes
