Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13565 )
Change subject: [java] Add unit tests demonstrating good behavior of scan tokens when range partitions are dropped ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java File java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java: http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java@340 PS2, Line 340: Dehydrate Technically you're hydrating them. http://gerrit.cloudera.org:8080/#/c/13565/2/java/kudu-client/src/test/java/org/apache/kudu/client/TestScanToken.java@351 PS2, Line 351: // Check the scanners work. The scanners for the tablets in the range [10, 20) definitely won't : // see any rows. The scanners for the tablets in the range [20, 30) might see rows. Have you looked into why this is? I would have expected a TABLET_NOT_FOUND error somewhere under the hood, surfaced as a NonRecoverableException. -- To view, visit http://gerrit.cloudera.org:8080/13565 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib25ea2b62321934313c9c8852f0bc00b28bf7f2b Gerrit-Change-Number: 13565 Gerrit-PatchSet: 2 Gerrit-Owner: Will Berkeley <wdberke...@gmail.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Comment-Date: Fri, 07 Jun 2019 23:31:37 +0000 Gerrit-HasComments: Yes
