Todd Lipcon has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/13556 )

Change subject: KUDU-2841. Expose HMS DB UUID to clients in HiveMetastoreConfig
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/13556/1/src/kudu/hms/hms_catalog.h
File src/kudu/hms/hms_catalog.h:

http://gerrit.cloudera.org:8080/#/c/13556/1/src/kudu/hms/hms_catalog.h@136
PS1, Line 136: Uuid(std::str
> other options might be GetUuid() or just uuid()
Done


http://gerrit.cloudera.org:8080/#/c/13556/1/src/kudu/hms/hms_client.cc
File src/kudu/hms/hms_client.cc:

http://gerrit.cloudera.org:8080/#/c/13556/1/src/kudu/hms/hms_client.cc@352
PS1, Line 352:   HMS_RET_NOT_OK(client_.get_metastore_db_uuid(*uuid),
             :                  "failed to get HMS DB UUID");
             :   return Status::OK();
             : }
             :
> Why the lambda?
ah, I had some other code in here that made me want the status, but no longer 
necessary



--
To view, visit http://gerrit.cloudera.org:8080/13556
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I393df4dd281c3fb63a836db346d7b33fb6edc6a2
Gerrit-Change-Number: 13556
Gerrit-PatchSet: 2
Gerrit-Owner: Todd Lipcon <t...@apache.org>
Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <granthe...@apache.org>
Gerrit-Reviewer: Hao Hao <hao....@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <t...@apache.org>
Gerrit-Comment-Date: Tue, 11 Jun 2019 18:18:11 +0000
Gerrit-HasComments: Yes

Reply via email to