Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13580 )
Change subject: [metrics] Merge metrics by table ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/13580/3/src/kudu/util/metrics.h File src/kudu/util/metrics.h: PS3: Since this is a fairly beefy patch to core infrastructure, mind splitting up the patch into two? 1. Cleanup only patch with no functional impact. 2. Patch that adds the merging functionality. http://gerrit.cloudera.org:8080/#/c/13580/3/src/kudu/util/metrics.h@436 PS3, Line 436: bool merge_by_table = false; See https://gerrit.cloudera.org/c/13376/2/src/kudu/util/metrics.cc#205: we want to keep code in util free of Kudu-specific abstractions like "tables" and "tablets". Sounds like you want to merge metrics based on attributes shared by their entities; is that right? Perhaps you could structure the new functionality in that way? -- To view, visit http://gerrit.cloudera.org:8080/13580 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8db3d082ae847eb1d83b9e4aee57d5e4bf13e1b5 Gerrit-Change-Number: 13580 Gerrit-PatchSet: 3 Gerrit-Owner: Yingchun Lai <405403...@qq.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Tue, 11 Jun 2019 23:53:57 +0000 Gerrit-HasComments: Yes
