helifu has posted comments on this change. ( http://gerrit.cloudera.org:8080/13426 )
Change subject: KUDU-2797: the master aggregates tablet metrics ...................................................................... Patch Set 6: (1 comment) How can I fix this issue except wrapping it with pointer? http://gerrit.cloudera.org:8080/#/c/13426/6/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/13426/6/src/kudu/tserver/ts_tablet_manager.cc@1568 PS6, Line 1568: unique_ptr<ReportedTabletStatsPB> pb(new ReportedTabletStatsPB()) > Do these need to be heap-allocated? Could we create the ReportedTableStatsP /mnt/ddb/2/helif/apache/kudu/src/kudu/tserver/ts_tablet_manager.h:403:12: required from here /usr/include/c++/4.9/bits/stl_pair.h:102:11: error: ‘std::pair<_T1, _T2>::second’ has incomplete type _T2 second; /// @c second is a copy of the second object ^ In file included from /mnt/ddb/2/helif/apache/kudu/src/kudu/tserver/tserver_path_handlers.cc:61:0: /mnt/ddb/2/helif/apache/kudu/src/kudu/tserver/ts_tablet_manager.h:72:7: error: forward declaration of ‘class kudu::master::ReportedTabletStatsPB’ class ReportedTabletStatsPB; ^ >>> Fixing #includes in >>> '/mnt/ddb/2/helif/apache/kudu/src/kudu/tserver/ts_tablet_manager.h' @@ -20,7 +20,6 @@ #include <cstdint> #include <functional> #include <map> -#include <memory> #include <string> #include <unordered_map> #include <unordered_set> @@ -32,7 +31,6 @@ #include "kudu/gutil/gscoped_ptr.h" #include "kudu/gutil/macros.h" #include "kudu/gutil/ref_counted.h" -#include "kudu/master/master.pb.h" #include "kudu/tablet/metadata.pb.h" #include "kudu/tserver/tablet_copy_client.h" #include "kudu/tserver/tablet_replica_lookup.h" >>> Fixing #includes in >>> '/mnt/ddb/2/helif/apache/kudu/src/kudu/tserver/ts_tablet_manager.cc' @@ -53,7 +53,7 @@ #include "kudu/gutil/map-util.h" #include "kudu/gutil/port.h" #include "kudu/gutil/strings/substitute.h" - +#include "kudu/master/master.pb.h" #include "kudu/rpc/result_tracker.h" #include "kudu/tablet/metadata.pb.h" #include "kudu/tablet/tablet.h" IWYU would have edited 3 files on your behalf. -- To view, visit http://gerrit.cloudera.org:8080/13426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I74406ab7cca7c22fda455c328b8ee9989a6b2d99 Gerrit-Change-Number: 13426 Gerrit-PatchSet: 6 Gerrit-Owner: helifu <hzhel...@corp.netease.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Mike Percy <mpe...@apache.org> Gerrit-Reviewer: helifu <hzhel...@corp.netease.com> Gerrit-Comment-Date: Wed, 12 Jun 2019 03:29:02 +0000 Gerrit-HasComments: Yes
