Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13599 )
Change subject: [sentry] Add ListPrivilegesByAuthoriablesAndUser sentry client API ...................................................................... Patch Set 3: (3 comments) http://gerrit.cloudera.org:8080/#/c/13599/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13599/3//COMMIT_MSG@9 PS3, Line 9: ListPrivilegesByAuthoriablesAndUser Typo here too. http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client-test.cc File src/kudu/sentry/sentry_client-test.cc: http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client-test.cc@194 PS3, Line 194: authorizables.insert(authorizable); This isn't testing multiple authorizables though. Could we add coverage for that too? http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client.h File src/kudu/sentry/sentry_client.h: http://gerrit.cloudera.org:8080/#/c/13599/3/src/kudu/sentry/sentry_client.h@114 PS3, Line 114: ListPrivilegesByAuthoriablesAndUser Should be "Authorizables". Also, maybe place near ListPrivilegesByUser so the connection is more clear? Also needs doc. -- To view, visit http://gerrit.cloudera.org:8080/13599 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia3232ad41cc827f593732072a6670c138d524bfb Gerrit-Change-Number: 13599 Gerrit-PatchSet: 3 Gerrit-Owner: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 13 Jun 2019 04:54:45 +0000 Gerrit-HasComments: Yes
