Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/13591 )
Change subject: KUDU-2846: optimize predicate evaluation for primitives ...................................................................... Patch Set 6: (2 comments) http://gerrit.cloudera.org:8080/#/c/13591/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/13591/6//COMMIT_MSG@8 PS6, Line 8: : This changes to an optimized unrolled-by-8 predicate evaluation for : primitive columns. > for AVX2 there aren't any parallel compare operations that can do more than Thanks for the explanation! SGTM http://gerrit.cloudera.org:8080/#/c/13591/3/src/kudu/common/column_predicate-test.cc File src/kudu/common/column_predicate-test.cc: http://gerrit.cloudera.org:8080/#/c/13591/3/src/kudu/common/column_predicate-test.cc@1538 PS3, Line 1538: pred.Evaluate(b, &selvec); > I just had this 'num_ret' bit to try to avoid the compiler completely optim Ack -- To view, visit http://gerrit.cloudera.org:8080/13591 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9dd062961a3cd2c892997d6aba12684e603628a1 Gerrit-Change-Number: 13591 Gerrit-PatchSet: 6 Gerrit-Owner: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Comment-Date: Thu, 13 Jun 2019 16:22:55 +0000 Gerrit-HasComments: Yes
