Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/13608 )
Change subject: KUDU-2850: fix thrift comparison ...................................................................... Patch Set 3: (2 comments) I'm late with at the party, but anyways. http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators-test.cc File src/kudu/sentry/thrift_operators-test.cc: http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators-test.cc@143 PS3, Line 143: ASSERT_EQ(5, authorizables.size()) << authorizables; I think in addition to that, it would make sense to populate a vector of TSentryAuthorizable out of the set and then compare the result with the reference vector. That's to have cover the total ordering of the elements in the set. http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators.cc File src/kudu/sentry/thrift_operators.cc: http://gerrit.cloudera.org:8080/#/c/13608/3/src/kudu/sentry/thrift_operators.cc@34 PS3, Line 34: { \ : if ((lhs) != (rhs)) { \ : return (lhs) < (rhs); \ : } \ : } nit: w.r.t. trailing semicolon when used, it might be a better fit to wrap the if() clause into 'do {} while (false)': do { ... } while (false) -- To view, visit http://gerrit.cloudera.org:8080/13608 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I071ccb08a385d6a4bfe407ab05621afe437bc29c Gerrit-Change-Number: 13608 Gerrit-PatchSet: 3 Gerrit-Owner: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Adar Dembo <a...@cloudera.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Hao Hao <hao....@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Comment-Date: Thu, 13 Jun 2019 17:32:21 +0000 Gerrit-HasComments: Yes
