Grant Henke has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13650 )
Change subject: KUDU-2846 (part 2): optimize IS [NOT] NULL predicates ...................................................................... KUDU-2846 (part 2): optimize IS [NOT] NULL predicates This does a simple optimization to use bitwise ops on the selection and null vectors to implement NOT NULL and NULL, rather than the current branchy code. The speedup is about 75x. Before: int32 NULL (c IS NULL) 615.9M evals/sec 4.54 cycles/eval int32 NOT NULL (c IS NOT NULL) 636.3M evals/sec 4.39 cycles/eval int32 NULL (c IS NOT NULL) 645.3M evals/sec 4.33 cycles/eval After: int32 NULL (c IS NULL) 46811.4M evals/sec 0.03 cycles/eval int32 NOT NULL (c IS NOT NULL) 45706.1M evals/sec 0.03 cycles/eval int32 NULL (c IS NOT NULL) 48855.0M evals/sec 0.03 cycles/eval Change-Id: I14fb75c7c330e2415fd7a877186f7ed41a1accce Reviewed-on: http://gerrit.cloudera.org:8080/13639 Tested-by: Kudu Jenkins Reviewed-by: Andrew Wong <aw...@cloudera.com> (cherry picked from commit fe7c1575946f8ace3eaaea8adf1d03caf4da3c34) Reviewed-on: http://gerrit.cloudera.org:8080/13650 Tested-by: Grant Henke <granthe...@apache.org> Reviewed-by: Will Berkeley <wdberke...@gmail.com> --- M src/kudu/common/column_predicate-test.cc M src/kudu/common/column_predicate.cc 2 files changed, 42 insertions(+), 24 deletions(-) Approvals: Grant Henke: Verified Will Berkeley: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/13650 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: branch-1.10.x Gerrit-MessageType: merged Gerrit-Change-Id: I14fb75c7c330e2415fd7a877186f7ed41a1accce Gerrit-Change-Number: 13650 Gerrit-PatchSet: 2 Gerrit-Owner: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Grant Henke <granthe...@apache.org> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Will Berkeley <wdberke...@gmail.com>
