Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13632 )
Change subject: KUDU-2823 Place tablet replicas based on range ...................................................................... Patch Set 7: (1 comment) http://gerrit.cloudera.org:8080/#/c/13632/7/src/kudu/tserver/ts_tablet_manager.cc File src/kudu/tserver/ts_tablet_manager.cc: http://gerrit.cloudera.org:8080/#/c/13632/7/src/kudu/tserver/ts_tablet_manager.cc@1260 PS7, Line 1260: auto* existing = InsertOrReturnExisting(&result, range, 1); : if (existing) { : (*existing)++; : } > nit: consider using LookupOrEmplace() for more clarity since it's not impor result[range]++ ought to work too, right? -- To view, visit http://gerrit.cloudera.org:8080/13632 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: kudu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I48a225e221eb42ef2f5489687e80a151d8dc1a42 Gerrit-Change-Number: 13632 Gerrit-PatchSet: 7 Gerrit-Owner: Yao Xu <oclarms....@gmail.com> Gerrit-Reviewer: Alexey Serbin <aser...@cloudera.com> Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com> Gerrit-Reviewer: Kudu Jenkins (120) Gerrit-Reviewer: Tidy Bot (241) Gerrit-Reviewer: Todd Lipcon <t...@apache.org> Gerrit-Reviewer: Yao Xu <oclarms....@gmail.com> Gerrit-Comment-Date: Mon, 17 Jun 2019 18:52:35 +0000 Gerrit-HasComments: Yes
